getType(): flatten named parameters before calling init() #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
See also #11 and horde/turba#21. |
amulet1
force-pushed
the
amulet1-issue-12
branch
from
2079075 to
9e0d4a5
Compare
amulet1
force-pushed
the
amulet1-issue-12
branch
2 times, most recently
from
a176f9b to
b683314
Compare
amulet1
force-pushed
the
amulet1-issue-12
branch
from
b683314 to
02d0a5d
Compare
amulet1
changed the title
Collaborator
Author
|
@TDannhauer Please merge. |
Collaborator
Author
|
See also #11 and horde/turba#21. |
Contributor
|
hi @amulet1 , is your proposal following approach A) or B) from the issue? I suggest we have a short call - maybe tomorrow - to discuss the approaches , pros and cons to select a road to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed fix to #12.
Here I am using
paramsfrom value returned byabout(). I had to adjust it in a few places (non--critical) to match original parameters names.